Conversation
| [target.'cfg(all(unix, not(target_env = "musl")))'.dependencies] | ||
| fspy_preload_unix = { workspace = true } | ||
| #[target.'cfg(all(unix, any(not(target_env = "musl"), not(target_os = "android"))))'.dependencies] | ||
| #fspy_preload_unix = { workspace = true } |
There was a problem hiding this comment.
fspy needs fspy_preload_unix on macOS and glibc Linux
There was a problem hiding this comment.
This ipc channel is only used by LD_PRELOAD. Since we won't use that in android (same as musl), we don't need to fix it for android. You can completely skip compiling this module.
There was a problem hiding this comment.
There was a problem hiding this comment.
Done, I excluded ipc module, like musl host
There was a problem hiding this comment.
Could you try adding not(target_os = "android") to
fspy_shared/src/ipc.
There was a problem hiding this comment.
Could you undo all the changes in crates/fspy_shared/src/ipc/channel? Thanks.
They aren't necessary since the channel module is properly gated.
There was a problem hiding this comment.
Done, crates/fspy_shared/src/ipc/channel content (mod.rs and shm_io.rs) is the same as main branch
There was a problem hiding this comment.
crates/fspy_shared/src/ipc/channel/mod.rs still contains lots of code changes, and they cause the CI failures. Could you undo them all?
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
Signed-off-by: Ludea <ludovicw35@hotmail.com>
|
Looks like the macOS test failures come from the gate change in -#[cfg(all(unix, not(target_env = "musl")))]
+#[cfg(all(target_os = "linux", not(target_env = "musl")))]
mod client; // same for interceptions, libc, macrosOn macOS that makes the preload crate compile empty, so Probably want |
Signed-off-by: Ludea <ludovicw35@hotmail.com>
|
@copilot resolve the merge conflicts in this pull request |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 747e02555e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
531e41d to
6da9e9a
Compare
c0cf7c7 to
09fa2e7
Compare
Add android support