Skip to content

Feature/fix input check #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
axlbonnet merged 3 commits into from
Jul 16, 2024
Merged

Feature/fix input check #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60ed805
Fix input check in VipLauncher.py
hippolyteblot Jul 16, 2024
8cf18fe
Changing version to 0.1.6a1
hippolyteblot Jul 16, 2024
d4ec992
Clarification of the input check comment
hippolyteblot Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vip_client/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"""

# Informations
__version__ = "0.1.4"
__version__ = "0.1.6a1"
__license__ = "CECILL-B"

from vip_client.classes import VipSession
5 changes: 4 additions & 1 deletion src/vip_client/classes/VipLauncher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1605,7 +1605,7 @@ def _check_invalid_input(self, input_settings: dict, parameters_ref=None):
for param in parameters_ref:
# Get parameter name
name = param['name']
# Skip irrelevant inputs (this should not happen after self._check_input_keys())
# Check only defined inputs
if name not in input_settings:
continue
# Get input value
Expand Down Expand Up @@ -1643,6 +1643,9 @@ def _check_input_values(self, input_settings: dict, location: str) -> None:
wrong_type_inputs = []
for param in self._pipeline_def['parameters']:
name = param['name']
# Check only defined inputs
if name not in input_settings:
continue
value = input_settings.get(name)
# If input is a File, check file(s) existence
if param["type"] == "File":
Expand Down