Skip to content

fix(slack): add clear modal response_action for view_submission#401

Open
Franz1241 wants to merge 4 commits intovercel:mainfrom
Franz1241:refactor/slack-modal-response-action-add
Open

fix(slack): add clear modal response_action for view_submission#401
Franz1241 wants to merge 4 commits intovercel:mainfrom
Franz1241:refactor/slack-modal-response-action-add

Conversation

@Franz1241
Copy link
Copy Markdown

Summary

  • Adds a fifth ModalClearResponse variant ({ action: "clear" }) to the SDK's ModalResponse union, bringing the abstraction to parity with Slack's five documented view_submission response semantics.
  • Wires it through the Slack adapter's modalResponseToSlack translator to emit { response_action: "clear" }, which dismisses the entire modal stack (vs. "close" / empty body, which only closes the submitted view).

Per the official Slack modals docs, view_submission supports 5 response shapes and only 4 were implemented

Test plan

pnpm validate 16/16 pass

Closes #400

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 18, 2026

@Franz1241 is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

ModalClearResponse type is not exported from the chat package entry point, making it unavailable to consumers despite being part of the exported ModalResponse union type.

Fix on Vercel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slack adapter missing "clear" action for Modal response

1 participant