[Bug] Catalogue Panel causing high precision decimal loss

[Driffx]

Summary

Values ​​are changed in the "Catalog > Known Technologies" fields

Confirm the following statements

• I have checked that this issue is relevant to the latest release of NMSE.
• I have searched the issue tracker and found no duplicate.
• I have searched the documentation and found nothing matching this issue.
• This issue contains only one bug report.
• I have read and agree to follow the code of conduct.

Description

Every time I load the save file and click on the Catalog tab, even without changing anything, the parameters/values ​​for the listed items are altered.

Issue 2 (not sure if correlated) : Even after adding everything previously, multiple times, Know Technologies continues to show several items that need to be added.

Known Products and Known Specials do not appear to be affected.

Expected behavior

The parameters should remain unchanged.

Steps to reproduce

1. Load a save file
2. Click on the Catalog tab. You don't need to change/add anything.
3. Go to Raw JSON Editor > Show Changes and view the changes.

Environment

OS Windows 11 25h2
NMSE v1.1.20 (preview)

Acceptance criteria

The parameters/values should remain unchanged.

Additional information

[davemager]

I can confirm this to be an issue with v1.1.20 - and all those changes (that I also see) are located in the BaseContext/PlayerStateData/FishingRecord/LargestCatchList path. If I had anything in the ExpeditionContext branch it might have also affected that (but I do not). For the record, mine produces 186 changes (I've caught a lot of fish - at least one of every type, manually and yes, it took me a while!).

[vectorcmdr]

There must be a data type casting issue causing precision issues of some kind I have overlooked.
Looking into it now.

Yeah, needs to change from float to double. They're silently losing precision.

[davemager]

Sorry to burst any bubbles - I still get the same 186 LargestCatchList changes in 1.1.28.

[vectorcmdr]

Absolutely bizarre. Will investigate further.

[vectorcmdr]

Hopefully found it. I changed all of the obvious call sites from float to double, but missed some that were being cast to and from string values which inherently makes them floats. I don't know what maniac at HG wanted to store billion+ numbers as text, but they've bit me in the butt a few times now.
Going to make the fix now and build some safeties around it to help catch any future string->non-integer values going back and forth.

[vectorcmdr]

New method and guards in place to solve the string based float imprecision by casting all to doubles.

• Ran the test against the synthetic test data and all passed.
• Ran the test harness against the real save data from @davemager save4.hg and all passed.
• Verified by testing live (loaded save4.hg -> goto Catalogue panel -> goto JSON edits diff -> no changes -> goto Companions and edit (extend change test) -> goto JSON edits diff - no extra diffs for high precision non-integrals numbers).

Closing this one out, but if it is still present somewhere after the sweep, please let me know and I will re-open the issue and get onto it as a priority.

[davemager]

I don't know what to say. It fixes the Companions tab but - and I don't know how I must have missed this before - I see similar rounding errors on three other tabs.
Multi-tools: 8 changes in save4.hg (some of which truncate by 2 digits and rounding)

Starships: 24 changes with truncation/rounding:

Fleet: 12 changes with truncation/rounding:

In an abundance of embarrassment, I have checked all other tabs this morning and these are the only three panels left that show this behaviour today.

[vectorcmdr]

Imagine my embarrassment to have missed those panels also lol
This will be the exact same problem and I should have checked the other panels as well.
I am going back through panel by panel to catch any remaining string to non-integer precision issues. Hopefully this time I won't miss any more.