-
Notifications
You must be signed in to change notification settings - Fork 59
Feat:added pint linter #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Meldiron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on first sight. Please allow us some more time to ensure linter changes didn't break any logic. There are many changes we need to go over.
|
@Meldiron any update on this?
|
|
Please sync your branch with |
stnguyen90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!
|
@mohitcharkha please resolve the merge conflicts |
|
THANK YOU! All changes merged 🥳 Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub. You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile. Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :) |
|
On 27-Jan-2023, at 8:05 PM, Christy Jacob ***@***.***> wrote:
THANK YOU! All changes merged 🥳
Please reach out to me on our Discord server <https://appwrite.io/discord> if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.
You can accept the invite by visiting https://github.com/orgs/appwrite/invitation <https://github.com/orgs/appwrite/invitation>. By joining our team, you will officially be an Appwrite maintainer on GitHub.
You can change your membership visibility settings <https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/publicizing-or-hiding-organization-membership>, so your new Appwrite team membership badge will show up on your personal GitHub profile.
Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues <https://github.com/search?q=org%3Aappwrite+org%3Autopia-php+org%3Aopen-runtimes+label%3Ahacktoberfest+created%3A%3E2021-01-01+state%3Aopen&type=issues&s=updated&o=asc> and help make Appwrite better :)
—
Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUUXXUPZOSBBSJYB7UEMNHLWUPMJJANCNFSM6AAAAAAREI4AVE>.
You are receiving this because you were mentioned.
Hi Christy,
I tried reaching out on Discord but it seems that you are not accepting messages from outside the network. So how do I claim my swags?
Thanks.
|
This PR is part of #4351
Linter has been implemented by taking inspiration from PR