Skip to content

Conversation

@mohitcharkha
Copy link
Contributor

This PR is part of #4351

Linter has been implemented by taking inspiration from PR

@stnguyen90 stnguyen90 linked an issue Oct 13, 2022 that may be closed by this pull request
4 tasks
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on first sight. Please allow us some more time to ensure linter changes didn't break any logic. There are many changes we need to go over.

@mohitcharkha
Copy link
Contributor Author

@Meldiron any update on this?

Looks good on first sight. Please allow us some more time to ensure linter changes didn't break any logic. There are many changes we need to go over.

@christyjacob4
Copy link
Contributor

Please sync your branch with main . It has fixes for the failing CI tests

@mohitcharkha mohitcharkha requested a review from Meldiron October 27, 2022 11:52
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!

@christyjacob4
Copy link
Contributor

christyjacob4 commented Dec 20, 2022

@mohitcharkha please resolve the merge conflicts

@christyjacob4 christyjacob4 merged commit 31046fd into utopia-php:main Jan 27, 2023
@christyjacob4
Copy link
Contributor

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

@mohitcharkha
Copy link
Contributor Author

mohitcharkha commented Feb 7, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

💄 Add Code Linter To ‘utopia-php/storage’

4 participants