-
Notifications
You must be signed in to change notification settings - Fork 11
fix: set resource limits, don't crop images when nothing changed #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Image
User->>Image: crop(width, height, gravity)
alt No cropping needed
Image-->>User: return self
else Cropping needed
Image->>Image: Perform crop operation
Image-->>User: return self
end
User->>Image: setResourceLimit(type, value)
Image->>Imagick: Set resource limit based on type
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/Image/Image.php(2 hunks)
🧰 Additional context used
🪛 GitHub Actions: CodeQL
src/Image/Image.php
[error] 568-573: Call to an undefined static method Imagick::setResourceLimits() reported by PHPStan.
🔇 Additional comments (1)
src/Image/Image.php (1)
109-109: LGTM: Return type annotation added.The explicit
selfreturn type declaration improves code clarity and type safety.
78f2703 to
9a33442
Compare
Summary by CodeRabbit