CICD 4347 Add Code Linter #81
Conversation
|
Please review this and let me know if any change is required |
|
Thank you so much for the PR 🤩. We're adding the |
|
Sure. Thank you! |
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Great PR! 🤯 Sorry, but it looks like there are conflicts now. Would you please resolve the conflicts and then we'll try to merge it in ASAP.
|
Done. I have resolved the conflicts |
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
@aaryan2134 for some reason, the build is failing now. Something may have happened while you were fixing the merge conflicts. Would you please fix the builds? You might want to clear out all your changes and run pint on a clean master.
|
I have removed all the changes made using code linter. But still the build is failing... |
|
I am not able to understand why this is not working... My build has been failing since the very first commit.. even without changing any files at all |
|
This worked finally! Thank you so much |
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!
|
@christyjacob4 could we please get this merged in ASAP to avoid merge conflicts? |
4 participants
Implemented Code Linter and corrected issues.
Auto fix issues using "code formatter"
No issues found with "code linter"
