Fix nested selections getting empty array when all are removed

[abnegate]

Summary by CodeRabbit

• Bug Fixes
  • Nested relationship queries now return all fields when a relationship is selected without specifying columns.
  • SELECT queries default to retrieving complete records when no specific fields remain after processing.
  • Improves consistency of related data retrieval and prevents missing fields in nested results.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Adds normalization in processRelationshipQueries to select all fields for nested relationships by default using [''] when no specific fields remain. Adjusts selection handling to issue [''] on empty nesting paths for SELECT queries. Minor indentation tweak in encodeSpatialData without functional change.

Changes

Cohort / File(s)	Summary
Relationship selection normalization src/Database/Database.php	- Default nested relationship selection to [''] when no remaining values after processing. - If nesting path after relation key is empty, issue nested selection of [''] rather than an empty path. - Minor indentation/formatting change in encodeSpatialData polygon handling; logic unchanged.

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant Database
  participant QueryBuilder

  Note over Client,Database: SELECT with nested relationship fields

  Client->>Database: processRelationshipQueries(query, selections)
  Database->>Database: Parse relation keys and nesting paths
  alt Nesting path empty or no remaining fields
    Note right of Database: Normalize to ['*'] to fetch all fields
    Database->>QueryBuilder: selectRelation(relation, ['*'])
  else Specific nested fields provided
    Database->>QueryBuilder: selectRelation(relation, fields[])
  end
  QueryBuilder-->>Client: Finalized query metadata

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Select nested relationships #643 — Also updates processRelationshipQueries to adjust handling/normalization of nested selections including '*'.
• Fix relationship select #632 — Refactors and fixes relationship select behavior in processRelationshipQueries, closely tied to defaulting and normalization logic.

Suggested reviewers

• fogelito

Poem

I twitch my nose at fields so bright,
Now '*' will gather all in sight. 🌟
Nested burrows, data deep,
Defaults ensure no bits will sleep.
A hop, a skip—queries aligned,
Carrots counted, every kind! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d59a207 and 45a1370.

📒 Files selected for processing (1)

• src/Database/Database.php (3 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-nested-select

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.