Fix min check

[abnegate]

Summary by CodeRabbit

• Bug Fixes

  • Improved enforcement of attribute value limits to correctly handle cases where limits are zero or other falsy values.

• Tests

  • Enhanced tests to specifically verify that the correct exception is thrown when attribute limits are violated.

[coderabbitai]

Walkthrough

This change updates the internal logic of the increaseDocumentAttribute and decreaseDocumentAttribute methods in the Database class to use explicit null checks for the $max and $min parameters, ensuring correct handling of zero and falsy values. Corresponding tests are refined to assert for the specific LimitException rather than a generic exception.

Changes

Cohort / File(s)	Change Summary
Database Limit Enforcement Logic src/Database/Database.php	Modified increaseDocumentAttribute and decreaseDocumentAttribute to explicitly check for null on $max and $min before enforcing limits.
Test Exception Specificity tests/e2e/Adapter/Scopes/DocumentTests.php	Refined testDecreaseLimitMin to assert for LimitException using explicit try-catch blocks instead of generic exceptions.

Sequence Diagram(s)

sequenceDiagram
    participant Test as Test Case
    participant DB as Database

    Test->>DB: increaseDocumentAttribute(attr, value, max)
    alt max is not null and result > max
        DB-->>Test: throw LimitException
    else
        DB-->>Test: return updated value
    end

    Test->>DB: decreaseDocumentAttribute(attr, value, min)
    alt min is not null and result < min
        DB-->>Test: throw LimitException
    else
        DB-->>Test: return updated value
    end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

• Fix PDOException on increment array attribute #605: Also modifies decreaseDocumentAttribute and increaseDocumentAttribute, focusing on disallowing array attributes, indicating overlap in method changes.
• Improve increment exceptions #603: Changes exception types thrown in decreaseDocumentAttribute and increaseDocumentAttribute, closely related to this PR's focus on exception handling.
• Return new value atomically #604: Refactors increaseDocumentAttribute and decreaseDocumentAttribute for transactional logic, touching the same methods with different internal updates.

Poem

A hop and a check for null in the code,
Ensuring limits set the proper load.
With tests that catch just what we seek,
No more surprises, no logic weak.
🐇✨ Code hops on, strong and neat!

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ec0e25 and f948a35.

📒 Files selected for processing (1)

• src/Database/Database.php (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/Database/Database.php

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Setup & Build Docker Image

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-dec-min-0

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.