fix: Revert "fix(web): avoid legacy dropdown id collisions"

[elibosley]

Reverts #1958

Summary by CodeRabbit

• Chores
  • Removed legacy dropdown element compatibility functionality.
  • Removed associated test coverage.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 834b748c-032c-42cf-94e9-e85007c533e3

📥 Commits

Reviewing files that changed from the base of the PR and between c392146 and 070d3cf.

📒 Files selected for processing (3)

• web/__test__/components/Wrapper/mount-engine.test.ts
• web/src/components/Wrapper/mount-engine.ts
• web/src/utils/dropdownIdCompatibility.ts

Disabled knowledge base sources:

• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

---

Walkthrough

This pull request removes dropdown ID compatibility functionality that previously normalized legacy dropdown-related DOM IDs and ARIA attributes. The changes eliminate the enableDropdownIdCompatibility() function, its invocation during app mounting, and the corresponding test case validating the sanitization behavior.

Changes

Cohort / File(s)	Summary
Dropdown ID Compatibility Removal web/src/utils/dropdownIdCompatibility.ts	Removed entire enableDropdownIdCompatibility() function that normalized dropdown-prefixed IDs (dropdown-*, dropdown-menu-*) to menu-prefixed form (menu-*) and applied continuous DOM mutation observation.
Integration & Test Cleanup web/src/components/Wrapper/mount-engine.ts, web/__test__/components/Wrapper/mount-engine.test.ts	Removed function call from mountUnifiedApp() and deleted test case that validated dropdown ID sanitization behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 No more dropdown ID regret,
Legacy patterns we forget,
Simpler code hops into place,
Cleaner codebase wins the race! 🏃‍♂️✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch revert-1958-codex/dropdown-id-compat

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 070d3cfea1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Re-enable dropdown ID sanitization during mount

Removing the enableDropdownIdCompatibility() call from mountUnifiedApp reintroduces the dropdown ID collision that #1958 fixed: Reka elements keep IDs like reka-dropdown-menu-*, so legacy plugins that target *dropdown-* can still match and immediately hide/break the Connect menu. This is a production regression for systems running those legacy plugins (the deleted regression test in this commit covered exactly this scenario).

Useful? React with 👍 / 👎.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.91%. Comparing base (c392146) to head (070d3cf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1961      +/-   ##
==========================================
- Coverage   51.94%   51.91%   -0.04%     
==========================================
  Files        1030     1029       -1     
  Lines       71137    71069      -68     
  Branches     7938     7917      -21     
==========================================
- Hits        36953    36896      -57     
+ Misses      34061    34050      -11     
  Partials      123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1961/dynamix.unraid.net.plg