Skip to content

feat(api): alert when usb boot has internal boot target #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elibosley merged 2 commits into from
Mar 12, 2026
Merged

feat(api): alert when usb boot has internal boot target #1898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
decf532
feat(api): alert when usb boot has internal boot target
Ajit-Mehrotra Mar 11, 2026
47a89fd
fix(api): harden internal boot alert bootstrap
Ajit-Mehrotra Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/src/unraid-api/graph/resolvers/array/array.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@ import { ParityService } from '@app/unraid-api/graph/resolvers/array/parity.serv
ArrayResolver,
ParityCheckMutationsResolver,
],
exports: [ArrayService],
})
export class ArrayModule {}
6 changes: 5 additions & 1 deletion api/src/unraid-api/graph/resolvers/disks/disks.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
import { Module } from '@nestjs/common';

import { ArrayModule } from '@app/unraid-api/graph/resolvers/array/array.module.js';
import { DisksResolver } from '@app/unraid-api/graph/resolvers/disks/disks.resolver.js';
import { DisksService } from '@app/unraid-api/graph/resolvers/disks/disks.service.js';
import { InternalBootNotificationService } from '@app/unraid-api/graph/resolvers/disks/internal-boot-notification.service.js';
import { NotificationsModule } from '@app/unraid-api/graph/resolvers/notifications/notifications.module.js';

@Module({
providers: [DisksResolver, DisksService],
imports: [ArrayModule, NotificationsModule],
providers: [DisksResolver, DisksService, InternalBootNotificationService],
exports: [DisksResolver, DisksService],
})
export class DisksModule {}
219 changes: 219 additions & 0 deletions api/src/unraid-api/graph/resolvers/disks/disks.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,225 @@ describe('DisksService', () => {
});
});

describe('getInternalBootDevices', () => {
it('should return disks that match the Unraid internal boot partition layout', async () => {
mockExeca.mockResolvedValue({
stdout: JSON.stringify({
blockdevices: [
{
name: 'sda',
path: '/dev/sda',
type: 'disk',
children: [
{
name: 'sda1',
path: '/dev/sda1',
type: 'part',
partlabel: 'BIOS Boot Partition',
parttype: '21686148-6449-6e6f-744e-656564454649',
},
{
name: 'sda2',
path: '/dev/sda2',
type: 'part',
partlabel: 'EFI System Partition',
parttype: 'c12a7328-f81f-11d2-ba4b-00a0c93ec93b',
},
{
name: 'sda3',
path: '/dev/sda3',
type: 'part',
partlabel: 'Unraid Boot Partition',
parttype: '0fc63daf-8483-4772-8e79-3d69d8477de4',
},
{
name: 'sda4',
path: '/dev/sda4',
type: 'part',
partlabel: '',
parttype: '0fc63daf-8483-4772-8e79-3d69d8477de4',
},
],
},
{
name: 'sdb',
path: '/dev/sdb',
type: 'disk',
children: [
{
name: 'sdb1',
path: '/dev/sdb1',
type: 'part',
partlabel: 'EFI System Partition',
parttype: 'c12a7328-f81f-11d2-ba4b-00a0c93ec93b',
},
],
},
],
}),
stderr: '',
exitCode: 0,
failed: false,
command: '',
cwd: '',
isCanceled: false,
} as unknown as Awaited<ReturnType<typeof execa>>);

const disks = await service.getInternalBootDevices();

expect(mockExeca).toHaveBeenCalledWith('lsblk', [
'-J',
'-o',
'NAME,PATH,TYPE,PARTLABEL,PARTTYPE',
]);
expect(disks).toHaveLength(1);
expect(disks[0]?.device).toBe('/dev/sda');
expect(disks[0]?.id).toBe('S4ENNF0N123456');
});

it('should return an empty array when lsblk fails', async () => {
mockExeca.mockRejectedValue(new Error('lsblk failed'));

await expect(service.getInternalBootDevices()).resolves.toEqual([]);
});

it('should exclude usb disks even when the partition layout matches', async () => {
vi.spyOn(service, 'getDisks').mockResolvedValue([
{
id: 'internal',
device: '/dev/sda',
type: 'HD',
name: 'Internal Boot',
vendor: 'Samsung',
size: 512110190592,
bytesPerSector: 512,
totalCylinders: 1,
totalHeads: 1,
totalSectors: 1,
totalTracks: 1,
tracksPerCylinder: 1,
sectorsPerTrack: 1,
firmwareRevision: '1',
serialNum: 'internal',
emhttpDeviceId: 'internal',
interfaceType: DiskInterfaceType.PCIE,
smartStatus: DiskSmartStatus.OK,
partitions: [],
isSpinning: false,
},
{
id: 'usb',
device: '/dev/sdb',
type: 'HD',
name: 'USB Clone',
vendor: 'SanDisk',
size: 128000000000,
bytesPerSector: 512,
totalCylinders: 1,
totalHeads: 1,
totalSectors: 1,
totalTracks: 1,
tracksPerCylinder: 1,
sectorsPerTrack: 1,
firmwareRevision: '1',
serialNum: 'usb',
emhttpDeviceId: 'usb',
interfaceType: DiskInterfaceType.USB,
smartStatus: DiskSmartStatus.OK,
partitions: [],
isSpinning: false,
},
]);
mockExeca.mockResolvedValue({
stdout: JSON.stringify({
blockdevices: [
{
name: 'sda',
path: '/dev/sda',
type: 'disk',
children: [
{
name: 'sda1',
path: '/dev/sda1',
type: 'part',
partlabel: 'BIOS Boot Partition',
parttype: '21686148-6449-6e6f-744e-656564454649',
},
{
name: 'sda2',
path: '/dev/sda2',
type: 'part',
partlabel: 'EFI System Partition',
parttype: 'c12a7328-f81f-11d2-ba4b-00a0c93ec93b',
},
{
name: 'sda3',
path: '/dev/sda3',
type: 'part',
partlabel: 'Unraid Boot Partition',
parttype: '0fc63daf-8483-4772-8e79-3d69d8477de4',
},
{
name: 'sda4',
path: '/dev/sda4',
type: 'part',
partlabel: '',
parttype: '0fc63daf-8483-4772-8e79-3d69d8477de4',
},
],
},
{
name: 'sdb',
path: '/dev/sdb',
type: 'disk',
children: [
{
name: 'sdb1',
path: '/dev/sdb1',
type: 'part',
partlabel: 'BIOS Boot Partition',
parttype: '21686148-6449-6e6f-744e-656564454649',
},
{
name: 'sdb2',
path: '/dev/sdb2',
type: 'part',
partlabel: 'EFI System Partition',
parttype: 'c12a7328-f81f-11d2-ba4b-00a0c93ec93b',
},
{
name: 'sdb3',
path: '/dev/sdb3',
type: 'part',
partlabel: 'Unraid Boot Partition',
parttype: '0fc63daf-8483-4772-8e79-3d69d8477de4',
},
{
name: 'sdb4',
path: '/dev/sdb4',
type: 'part',
partlabel: '',
parttype: '0fc63daf-8483-4772-8e79-3d69d8477de4',
},
],
},
],
}),
stderr: '',
exitCode: 0,
failed: false,
command: '',
cwd: '',
isCanceled: false,
} as unknown as Awaited<ReturnType<typeof execa>>);

const disks = await service.getInternalBootDevices();

expect(disks).toHaveLength(1);
expect(disks[0]?.device).toBe('/dev/sda');
});
});

// --- Test getTemperature ---
describe('getTemperature', () => {
it('should return temperature for a disk', async () => {
Expand Down
Loading
Loading