fix: generationtask not finding host on net10 builds #168
+588
−2,675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpinedam
force-pushed
the
fix/not.finding.generation.host
branch
from
cc538b1 to
c86d5a5
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the SourceGenerationTask fails to correctly parse version numbers for .NET 10 and higher. The issue stems from the original code extracting only a single character from the framework description string, which works for single-digit versions (.NET 6-9) but breaks for multi-digit versions (.NET 10+).
- Replaced single-character extraction with proper version string parsing using
Substring,Split, andint.TryParse - Added proper error handling with a fallback to "net6" if parsing fails
- Maintains backward compatibility with existing .NET versions while supporting .NET 10+
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Xiaoy312
approved these changes
Dec 16, 2025
jeromelaban
approved these changes
Dec 16, 2025
Author
|
@copilot do you know how to fix those build errors? |
|
@ajpinedam I've opened a new pull request, #169, to work on those changes. Once the pull request is ready, I'll request review from you. |
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
spouliot
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #167
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):