Fix NullReferenceException on SpringBonePivotInspector after reloading scripts #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for the PR, We have reproduced the issue following the procedure you reported and confirmed that your PR fixes it. Thank you very much for your corporation. |
H3idi-X
added a commit
that referenced
this pull request
Oct 16, 2021
* Add localization and make default language to English * update package version and supported Unity version due to localization support * fixed assembly issue during build * Add conditional localization import Localization API moved in 2020.1 and 2020.2 * Mark v1.2.0-preview.0 (unlikely name) * Adjust version to 1.2.1-preview.0 Technically based off 1.2.1-preview, but package manifest originally listed 1.2.0-preview * Consider model scale (#11) Even if the model is scaled, the size of the gizmo will not be scaled. So you can't set the collision. This change will take scale into account and fix it to work correctly. * Call SpringBoneGUIStyles.ReacquireStyles() on SpringBonePivotInspector (#12) * Updated CHANGELOG.md package.json Added upm-ci * Re-added some to CHANGELOG.md. * Updated upm-ci file to check web-hook on GitHub. * updated upm-ci-SpringBone.yml * Set up tentative enviroment just to make the project can pass yamato-ci.test. * Fixed: old mac build farm in upm-ci * Added Tests.meta to avoid yamato-ci errors. * added Tests.meta to .gitattribute Co-authored-by: Hiroki Omae <[email protected]> Co-authored-by: riina <[email protected]> Co-authored-by: tyfkda <[email protected]> Co-authored-by: YuukiARIA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reloading scripts, selecting SpringBonePivot objects before selecting any other components (SpringBoneManager, SpringBone, ...) causes NullReferenceException.
It seems that
SpringBoneGUIStyles.ButtonStyleis not initialized.To fix this, simply add calling
SpringBoneGUIStyles.ReacquireStyles()before drawing the inspector.