Merged
Conversation
perry-mitchell
approved these changes
Feb 3, 2025
Closed
Contributor
|
There is a regression in current master branch. (master)> yarn build
(master)> git diffdiff --git a/dist/index.js b/dist/index.js
index a7aedbf..ad91831 100644
--- a/dist/index.js
+++ b/dist/index.js
@@ -56,7 +56,7 @@ export function encodeTime(now, len) {
if (now < 0) {
throw createError("time must be positive");
}
- if (Number.isInteger(Number(now)) === false) {
+ if (Number.isInteger(now) === false) {
throw createError("time must be an integer");
}
let mod;This PR modifies the transpiled distribution code and does not appear to be an appropriate fix. |
Merged
Contributor
|
I created PR for this. take a look at #114. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am changing syntax according to the need.