Update CustomSVGSeries to use getX / getY #1051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
mcnuttandrew
left a comment
mcnuttandrew
left a comment
There was a problem hiding this comment.
Great catch. This is super reasonable! Would you mind adding an accessor to one of the example CustomSVGSeries in the showcase just so we can sanity check/test this behaviour?
Contributor
Author
|
@mcnuttandrew Sorry for the delays, updated an example now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this problem when I refactored my graphs to use getX / getY rather than previously data.map to conform to x and y keys, and in doing so made my icons disappear as they had NaN as their x and y.
This has been successful in fixing them.