Fix error handling when no features are found and remove force casting#149
Merged
nathanfallet merged 1 commit intotwostraws:mainfrom Dec 1, 2024
Merged
Conversation
…r, and also it uses force cast
|
Could this be merged? |
Contributor
Author
|
Yes |
nathanfallet
approved these changes
Dec 1, 2024
| if qrCodeLink.isEmpty { | ||
| didFail(reason: .badOutput) | ||
| } else { | ||
| if features.isEmpty { |
Collaborator
There was a problem hiding this comment.
Could have used a guard here too; but it's okay anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that the application properly handles cases where no features are found, preventing silent failures.
Removes the use of force casting, improving code safety and reliability.