Ability to continuously scan by ignoring specific codes#130
Merged
nathanfallet merged 1 commit intotwostraws:mainfrom Feb 23, 2024
Merged
Ability to continuously scan by ignoring specific codes#130nathanfallet merged 1 commit intotwostraws:mainfrom
nathanfallet merged 1 commit intotwostraws:mainfrom
Conversation
Contributor
Author
|
Another one please @nathanfallet (there's one more 🙏) |
TheGeekMax
approved these changes
Feb 23, 2024
TheGeekMax
left a comment
TheGeekMax
left a comment
There was a problem hiding this comment.
LGTM (reviewing from a friend's account cause I'm not at home)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem statement:
When scanning the same barcode again (either right away or after scanning another product) - could be done by continuous option, but the handler would be called each time which could be undesirable (for example, presenting a sheet when a code is detected). Using oncePerCode kind of does the trick, but scanning the same code again doesn't work as the name suggests.
Solution:
Ability to recognize any barcode except the specific "ignored" list which could let us put the current barcode into the ignored list and once another code is detected we update the list (like a "dynamic oncePerCode")