found each QR code separately in manual mode#104
Merged
nathanfallet merged 1 commit intotwostraws:mainfrom Mar 30, 2023
Merged
Conversation
Collaborator
|
I think it would be better to call the method with an array, so that we keep the fact that codes where scanned at the same time, calling only once the handler (the handler might not be doing great if called multiple times) |
Contributor
Author
In that case, the completion method should change to an array. |
Collaborator
|
You're right. |
nathanfallet
approved these changes
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
found each QR code separately in manual mode for 2 or more QR in one picture