[#89] Use the Ultra WIde Camera per default if available#102
Merged
nathanfallet merged 2 commits intotwostraws:mainfrom Mar 9, 2023
bennokress:feature/89-use-ultrawide-camera
Merged
[#89] Use the Ultra WIde Camera per default if available#102nathanfallet merged 2 commits intotwostraws:mainfrom bennokress:feature/89-use-ultrawide-camera
nathanfallet merged 2 commits intotwostraws:mainfrom
bennokress:feature/89-use-ultrawide-camera
Conversation
Autofocus on devices that are equipped with an Ultra Wide Camera seems to be off using the default Camera. This is why we select the Ultra Wide Camera per default now.
Contributor
Author
|
I honestly don't know if a public extension on |
Closed
|
@nathanfallet - This fix caused a bug with iPhone 12 Pro and 13 Pro. We faced issue that the camera cannot focus the code-128 on a device. I had to change videCaptureDevice to AVCaptureDevice.default(for: .video) in order to work as expected. |
Contributor
Author
Collaborator
|
I'm reopening #89 until we find an appropriate solution then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autofocus on devices that are equipped with an Ultra Wide Camera seems to be off using the default Camera. This is why we select the Ultra Wide Camera per default now.
Fixes #89