Add tests to ensure all rules are added to their rulesets#97
Merged
Conversation
There have been a couple of instances where a new rule wasn't added to its ruleset which caused it not to be active in specific versions of the library. With this change, we are able to proactively detect this (which is a very common occurence, it's so easy to forget this step!)
mrmans0n
requested review from
YoaliSB,
blundell,
chrisbanes,
digitalbuddha,
flubarb,
jordanterry,
kenyee,
sierraobryan and
taysand
chrisbanes
reviewed
Oct 7, 2022
...ktlint/src/test/kotlin/com/twitter/compose/rules/ktlint/TwitterComposeRuleSetProviderTest.kt
Show resolved
Hide resolved
chrisbanes
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been a couple of instances where a new rule wasn't added to its ruleset which caused it not to be active in specific versions of the library. With this change, we are able to proactively detect this (which is a very common occurence, it's so easy to forget this step!)