Merged
Conversation
Author
|
@tve ok now we should be good. Can you try with these changes... |
bcbfaa8 to
bd1058b
Compare
…client() has a case to handle this.
95f9f80 to
eb6630f
Compare
Author
|
Only issue I have is closing the connection or calling delete on the AsyncClient pointer. Do you have issues with closing/disconnects? fwiw, I recall having this problem before even using TLS changes. |
tve
reviewed
Jan 21, 2020
Owner
tve
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I don't think this is ready yet, though...
Owner
|
Great! Thanks! |
Author
|
Did you squash and merge? Preserving the commits with a rebase may have been better to keep history and easier merge for @me-no-dev |
Owner
|
Yes, I did squash, sorry, I'm too used to it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-- fix for cmake