Add example of colouring branches in a focal tree#164
Merged
petrelharp merged 2 commits intotskit-dev:mainfrom Mar 1, 2022
Merged
Add example of colouring branches in a focal tree#164petrelharp merged 2 commits intotskit-dev:mainfrom
petrelharp merged 2 commits intotskit-dev:mainfrom
Conversation
petrelharp
reviewed
Mar 1, 2022
petrelharp
reviewed
Mar 1, 2022
Contributor
|
I made some suggestions. This is excellent! |
Member
Author
|
All LGTM. For some reason I'm getting "Invalid email for web commit." when trying to accept your changes, so if you can accept them for me and merge, just go ahead. |
Member
Author
|
The other possibility is to put this in the "examples" section at the end of the viz tutorial. |
Contributor
Whoops - just saw this after I merged. As you see fit. |
Contributor
|
Hm, yes - that's a good idea, though. |
Member
Author
|
It's done now! Let's leave it for the moment: I will have to change the ARG viz examples anyway, so could move it at the same time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with @petrelharp on slack