Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3373 +/- ##
=======================================
Coverage 89.76% 89.76%
=======================================
Files 29 29
Lines 31286 31286
Branches 5738 5738
=======================================
Hits 28083 28083
Misses 1794 1794
Partials 1409 1409
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
|
I thought https://github.com/tskit-dev/tskit/blob/main/.circleci/config.yml#L200 already covered this? |
Member
Author
|
Ah yes, good point - I've deleted the tests from CircleCI (which are less comprehensive) |
Also remove package tests from circlCI
4c9ac8f to
a94a1d3
Compare
Member
Author
|
I think this is ready for merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on similar approach taken in tskit-dev/msprime#2471
Would be worth generalising from here so that this can be used across ecosystem