-
Notifications
You must be signed in to change notification settings - Fork 12
Areas not covered by code #52
Copy link
Copy link
Open
Labels
good first issueGood for newcomersGood for newcomers
Milestone
Description
There are a number of cases that the test suite doesn't cover. This issue lists a few, that should be added to unit tests:
- test a case where a binary node turns into a unary node in a later tree
- test a case where a sample node is internal (not sure if this is allowed, though)
- test for sensible failure when a node_to_date has no children (i.e. a dangling node)
- test for success when a node_to_date has a single, dated (sample) child (i.e. a unary node above a sample)
- the functions
forwards_mean_var&restrict_ages_toposeem not to be covered in test_functions.py. They should be, and thenodes_to_dateparameter tested - the caching of node mixtures is not tested, as none of the tests have duplicate node mixtures (this should be easy to test). Also there are no tests with large mixtures (number of descendant samples > 5)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers