Skip to content

[JS] PositionedKeywordsRule (require)#2

Open
trolit wants to merge 1 commit intomainfrom
feature/positioned-keywords-test-js
Open

[JS] PositionedKeywordsRule (require)#2
trolit wants to merge 1 commit intomainfrom
feature/positioned-keywords-test-js

Conversation

@trolit
Copy link
Owner

@trolit trolit commented Jul 31, 2022

No description provided.

Comment on lines +3 to +11
const test2 = require('@/helpers/helper2');

module.exports = (a, b) => {
const sum = a + b;

return sum;
};

const lodash = require('lodash');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 7 line(s) between require lines 3 and 11 but there shouldn't be any

Comment on lines +11 to +13
const lodash = require('lodash');

const test3 = require('@/helpers/helper3');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 1 line(s) between require lines 11 and 13 but there shouldn't be any

return sum;
};

const lodash = require('lodash');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 11 (packages) should appear before line 2 (other)

Expected order:
packages >> other

@patchron
Copy link

patchron bot commented Jul 31, 2022

pull request review completed

💬 4 comment(s) require attention.
🔨 1 commit(s)
➕ 13 additions
➖ 0 deletions
➗ 1 changed files

@trolit trolit force-pushed the main branch 3 times, most recently from 459394f to d8a500d Compare September 2, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant