Revert strong regex changes from #644 for legacy IAB implementation (#688)#690
Open
Crozzers wants to merge 1 commit intotrentm:masterfrom
Open
Revert strong regex changes from #644 for legacy IAB implementation (#688)#690Crozzers wants to merge 1 commit intotrentm:masterfrom
Crozzers wants to merge 1 commit intotrentm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #688, which is due to the changed rules around strong/em introduced in #665.
In that PR, alot of previously valid strong/em examples became invalid.
In theory, users could do the following to restore the existing behaviour:
But #644 changed the strong regex before being superseded by #665 in the same release cycle.
Since that change was never actually released, it may make sense to revert it so that users can opt back into the old IAB behaviour for compatibility