feat(forge-std): Replaces ds-test with forge-std#214
Closed
refcell wants to merge 21 commits intotransmissions11:mainfrom
Closed
feat(forge-std): Replaces ds-test with forge-std#214refcell wants to merge 21 commits intotransmissions11:mainfrom
refcell wants to merge 21 commits intotransmissions11:mainfrom
Conversation
src/test/SSTORE2.t.sol
Outdated
Comment on lines
+145
to
+148
| if (testBytes.length == 0) return; | ||
| endIndex = bound(endIndex, testBytes.length + 1, type(uint256).max - 1); | ||
| startIndex = bound(startIndex, testBytes.length + 1, type(uint256).max - 1); | ||
| if (startIndex > endIndex) (startIndex, endIndex) = (endIndex, startIndex); |
Owner
There was a problem hiding this comment.
why can't we use the previous code again? because of the plus 1? maybe we just allow overflow
Contributor
Author
There was a problem hiding this comment.
Otherwise I believe it errors with an arithmetic
Contributor
Author
There was a problem hiding this comment.
this way it ensures it reverts with "OUT_OF_BOUNDS"
Co-authored-by: t11s <greenfeatherhelp@gmail.com>
Owner
|
damn the tests run slow af with assume |
3 tasks
Owner
|
wai close im sorry im slow |
Contributor
Author
|
Owner
|
lmao |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modernizes the test suite to use
forge-stdrather thands-test.Checklist
forge snapshot?npm run lint?forge test?