Skip to content

"bound" not marked as "virtual" on "v7" branch #290

@PaulRBerg

Description

@PaulRBerg

I have recently created a PR in the Foundry Book repo to bump the version of Solmate recommended for users to install.

But it looks like the v7 branch has a problem - it doesn't adhere to the agreement discussed in foundry-rs/forge-std#92, that is, that the bound function will have a virtual modifier.

This means that users cannot inherit from both Forge Std's Test and DSTestPlus.

I would have created a PR to fix this myself, but it looks like on the main branch, the bound function does have the virtual modifier. So maybe you want to merge main into v7 rather than hot-patch it directly it on v7?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions