sync latest headers #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toyobayashi
force-pushed
the
update-headers
branch
from
1d6f513 to
2b52b0a
Compare
toyobayashi
force-pushed
the
update-headers
branch
from
5e92326 to
628ac61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodejs/node#49037
The update of node-api-headers may not be timely. Keep the built-in header file so that emnapi can respond to changes in Node-API at any time.
Additional suggestion to users:
-DBUILDING_NODE_EXTENSION-DNAPI_EXTERN=__attribute__((__import_module__("env")))manually sincenapiis the default module where Node.js wants to import symbols from. see Support custom import namespace for functions implemented in JavaScript emscripten-core/emscripten#20035