Open
Conversation
isbm
added
documentation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reintroduces TLS for the embedded Web API and updates the Web API authentication/request flow to use bearer tokens over HTTPS, alongside substantial secure-transport protocol and implementation updates (ephemeral key exchange + version negotiation) with expanded tests and documentation.
Changes:
- Start the embedded Web API over rustls (and disable it when TLS isn’t configured), with new
api.tls.*master configuration options and supporting docs/scripts. - Switch Web API auth/query flows to bearer tokens + plain JSON over HTTPS; update sysclient accordingly and add contract tests.
- Update secure transport bootstrap protocol shapes and implementation (supported versions + Curve25519 ephemeral keys), plus additional transport tests/docs/fixtures.
Reviewed changes
Copilot reviewed 56 out of 58 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
libwebapi/src/lib.rs |
Starts embedded Web API over rustls; TLS config loading and logging. |
libwebapi/src/api/v1/{system,minions,model,store}.rs |
Bearer-token auth enforcement and API contract updates. |
libsysinspect/src/cfg/mmconf.rs |
Adds api.tls.* config fields with rooted path resolution. |
sysmaster/src/master.rs |
Switches to start_embedded_webapi. |
sysclient/src/lib.rs (+ tests) |
Client updated to HTTPS default + bearer auth; new unit/contract tests. |
libsysinspect/src/transport/{secure_bootstrap,secure_channel}.rs (+ tests) |
Secure transport protocol/crypto changes with expanded test coverage. |
libwebapi/tests/api_contract.rs |
HTTPS API contract tests using rustls. |
scripts/dev-tls.sh / docs / examples |
Developer TLS helper + updated operator docs + protocol fixtures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 61 out of 63 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This [re]adds TLS to the WebAPI.