fix(backup): reload backup service on plugin initialization#428
Merged
thomasmny merged 3 commits intothomasmny:masterfrom Mar 15, 2026
Merged
fix(backup): reload backup service on plugin initialization#428thomasmny merged 3 commits intothomasmny:masterfrom
thomasmny merged 3 commits intothomasmny:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the backup subsystem so the auto-backup scheduler can be restarted/cancelled when configuration is reloaded, ensuring changes to AutoBackup.enabled take effect without a full plugin restart.
Changes:
- Track the auto-backup
BukkitTaskinBackupServiceand add areload()method to restart/cancel it based on current config. - Ensure
Config.load()refreshes its cachedFileConfigurationreference afterreloadConfig(). - Invoke
backupService.reload()after config reload.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| buildsystem-core/src/main/java/de/eintosti/buildsystem/world/backup/BackupService.java | Stores the scheduled task and adds reload() to restart/cancel auto-backups based on config. |
| buildsystem-core/src/main/java/de/eintosti/buildsystem/config/Config.java | Makes CONFIG reassignable and refreshes it in load() so reloads use the latest config instance. |
| buildsystem-core/src/main/java/de/eintosti/buildsystem/BuildSystemPlugin.java | Calls backupService.reload() as part of reloadConfigData. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
buildsystem-core/src/main/java/de/eintosti/buildsystem/BuildSystemPlugin.java
Outdated
Show resolved
Hide resolved
buildsystem-core/src/main/java/de/eintosti/buildsystem/world/backup/BackupService.java
Show resolved
Hide resolved
Owner
|
Hi @TWME-TW, thanks for the PR! Could you please address Copilot's reviews? |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.