Merged
Conversation
hidakatsuya
force-pushed
the
add-readme-of-section-report
branch
3 times, most recently
from
0b50f20 to
ca07063
Compare
Member
Author
|
@maeda-m レピューお願いします。 |
maeda-m
approved these changes
Jul 10, 2021
Member
maeda-m
left a comment
maeda-m
left a comment
There was a problem hiding this comment.
@hidakatsuya いつもありがとうございます。
LGTM!!
次の内容がわかる優れたREADMEだと思いました。
- 今どういった状況なのか？
- どうすれば使用できるのか？
- これまでの経緯（関連リンク）
section-report/README.md
Outdated
| ### Running tests | ||
|
|
||
| ``` | ||
| npm run test:units |
Member
There was a problem hiding this comment.
Suggested change
| npm run test:units | |
| npm run test:unit |
Member
Author
There was a problem hiding this comment.
thx! fixes and fixup are done.
hidakatsuya
force-pushed
the
add-readme-of-section-report
branch
from
ca07063 to
be03889
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.