Merged
Conversation
Owner
|
I'm cool with this PR. Squash it down to one commit and I'll merge it. Thanks! |
Owner
|
Can you add a couple tests for this? It looks good, but I'd like to keep the test coverage solid. Thanks. |
added intensifiers functionality, adjective multiply the effect of positive or negative words updated readme with adjectives examples modified intlist added tests for negative adjectives added callback to functions in test fixed assertion fixed tests fixed tests added neg tests fixed tests fixed tests added positive tests fixed positive tests modified intlist
Contributor
Author
|
Done, with test cases. Thanks! |
thinkroth
added a commit
that referenced
this pull request
Jan 6, 2013
Added intensifier adjectives.
Owner
|
Awesome. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Word list now has positive words, negative words and intensifier adjective words. The adjectives contribute with multiplicative factors to the sentimental value of the statements.
ex: "I am happy" returns score 3, "I am so happy" returns score 6, "I am ecstatically happy" returns score 9. The same adjectives have the same multiplicative factors for negative words, and thus increase the negativity value of the sentence.
Cheers! :)