fix: add BYOK/third-party API proxy support for SDK Agent #329
+151
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add settingSources: ['user'] to SDK query options to load user's API settings from ~/.claude/settings.json (fixes BYOK authentication) - Add workingDirectory option to ensure Claude subprocess runs in trusted location - Add SDK internal prompt filters at both hook and API levels to prevent SDK system prompts from being saved to user_prompts table Fixes: SDK Agent fails with 'Your account does not have access to Claude Code' error for users using ANTHROPIC_BASE_URL proxy
- Add loadClaudeCodeApiSettings() to worker-service.ts to load BYOK config (ANTHROPIC_BASE_URL and ANTHROPIC_AUTH_TOKEN) from ~/.claude/settings.json and set as environment variables at worker startup - Update SDKAgent.ts to use settingSources: [] which prevents loading any user settings including hooks, avoiding SDK subprocess triggering claude-mem hooks and creating infinite recursion - Add defensive filter in SessionRoutes.ts to detect SDK internal prompts by checking if project name equals home directory name, with fallback pattern matching for known SDK prompt prefixes This fixes an issue where BYOK users would see SDK internal prompts (like 'You are a Claude-Mem...' and 'PROGRESS SUMMARY CHECKPOINT') incorrectly saved to the user_prompts database table.
Owner
|
@claude review |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
The settingSources: [] fix prevents SDK subprocess from loading hooks, making the pattern filtering dead code that can never execute. Changes: - Remove SDK prompt pattern filtering from new-hook.ts - Remove SDK filtering and homedir detection from SessionRoutes.ts - Add 5-second timeout to apiKeyHelper execSync to prevent hangs 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Owner
Auto code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Refactor API key loading in WorkerService and SDKAgent - Updated WorkerService to load custom API key from ~/.claude-mem/settings.json for SDK Agent. - Removed environment variable settings from WorkerService; now only logs API key presence. - Introduced buildSDKEnvironment method in SDKAgent to explicitly pass API credentials to subprocess. - Enhanced logging for API key and base URL loading, ensuring better visibility during startup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SDK Agent fails with
"Your account does not have access to Claude Code. Please run /login."error for users using BYOK (Bring Your Own Key) with third-party API proxies (e.g.,ANTHROPIC_BASE_URL).Root Cause: The SDK Agent spawns a Claude subprocess that doesn't inherit the custom API settings from
~/.claude/settings.json, causing it to try default Anthropic authentication which fails.Additionally, when loading user settings with
settingSources: ["user"], the SDK subprocess also loads the claude-mem hooks configuration, causing SDK internal prompts to be incorrectly saved to theuser_promptstable.Solution
1. BYOK Support (Source-level fix)
loadClaudeCodeApiSettings()method toworker-service.tsthat reads BYOK config from~/.claude/settings.jsonand setsANTHROPIC_BASE_URLandANTHROPIC_AUTH_TOKENas environment variables at worker startupsettingSources: [](empty) in SDK Agent to prevent loading any user settings including hooks2. Defensive SDK Prompt Filter (Fallback)
SessionRoutes.tsto detect SDK internal sessionsprojectname equals home directory name (SDK runs withworkingDirectory: homedir())Changes
src/services/worker-service.ts: AddloadClaudeCodeApiSettings()method to load BYOK configsrc/services/worker/SDKAgent.ts: UsesettingSources: []to prevent loading hookssrc/hooks/new-hook.ts: Add SDK prompt filter at hook levelsrc/services/worker/http/routes/SessionRoutes.ts: Add SDK prompt filter at API level with home directory detectionWhy This Approach
Using
settingSources: []is cleaner than filtering because:Testing
settingSources: []skipped: false)