-
-
Notifications
You must be signed in to change notification settings - Fork 397
Add Makefile for development shortcuts #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jellydn
wants to merge
9
commits into
thedotmack:main
Choose a base branch
from
jellydn:add-makefile-development-shortcuts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Makefile for development shortcuts #216
jellydn
wants to merge
9
commits into
thedotmack:main
from
jellydn:add-makefile-development-shortcuts
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides convenient make targets that wrap existing npm scripts, improving developer experience with shorter commands. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <[email protected]>
Author
- Update version badge in README from 6.5.0 to 7.1.0 - Update Makefile help text: PM2 -> Bun worker references - Fix worker-logs-no-flush Makefile target to directly tail logs - Update What's New section to highlight v7.1.0 architectural migration - Update development shortcuts documentation
Aligns with v7.1.0 migration to Bun as primary package manager.
Updates: - src/services/worker/BranchManager.ts: bun install in branch switching and updates - src/shared/hook-error-handler.ts: bun run worker:restart in error messages - src/shared/worker-utils.ts: bun run worker:start/restart in startup errors - src/servers/mcp-server.ts: bun run worker:restart in worker availability check - scripts/publish.js: bun run build and bun test - scripts/sync-marketplace.cjs: bun run sync-marketplace:force in user guidance - CLAUDE.md: All build command examples updated to bun - README.md: Development setup and troubleshooting examples updated to bun Aligns with v7.1.0 Bun-based architecture migration.
Creates Architecture Decision Record documenting: - Context: Why PM2 was problematic (external dependency, platform complexity, auto-install friction) - Decision: Replace with custom Bun-based ProcessManager using PID file tracking - Consequences: Reduced dependencies, simpler cross-platform support, manual PID cleanup trade-off - Alternatives: systemd/launchd (too OS-specific), Node.js child_process (unnecessary complexity) Adds ADR directory structure and index per adr.github.io format.
- Add make build-and-sync, make build, make sync, and make worker-restart shortcuts - Add make worker-logs for viewing worker service logs - Update CLAUDE.md with complete build commands and environment setup - Update MCP server and worker service scripts
2a9a802 to
014606d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Summary
Adds comprehensive Makefile development shortcuts and updates CLAUDE.md documentation for improved developer experience.
What
Makefilewith development shortcuts mirroring npm scriptsmake build,make build-and-sync,make sync,make worker-restart,make worker-logsbun, override withNPM=npm)Why
Improves developer experience with shorter commands and familiar Make interface. Reduces typing friction during local development while maintaining full compatibility with existing npm scripts. Ensures documentation reflects latest architecture changes and provides clear guidance on build processes.
How
.PHONYtargets prevent file conflictsmake helpshows all available commandsChanges
build-and-sync,build,sync,worker-restart,worker-logstargetsTest Plan
make helpto verify all targets listedmake build-and-synccompiles and syncs successfullymake worker-restartrestarts Bun workermake worker-logsdisplays worker logsNPM=npm make builduses npm instead of bun🤖 Generated with Claude Code