Add docker compose module with V2 support#400
Add docker compose module with V2 support#400carlosemart wants to merge 6 commits intotestcontainers:mainfrom
Conversation
|
linking also #358 |
alexanderankin
left a comment
There was a problem hiding this comment.
if i approve this, do tests run?
|
@alexanderankin, I don't know who should approve the pr, but there should be an "Approve and run" button like this one: |
91ab9ae to
91fff1c
Compare
|
I rebase main branch with poetry changes |
91fff1c to
97b2ede
Compare
|
hey @carlosemart sorry for the disappiontment, we've decided to rewrite the compose from the ground up, because it isn't just a matter of see #426 of course, your review is welcome on the PR, however I would like to avoid duplicating the effort on multiple PRs. |
|
No problem @totallyzen, I made the pr to be continuist with the 3.x versions but it is true that taking advantage of the change of major version the deepest changes have much more sense. |
|
Duplicate with #426 |

Co-authored-by: @jhnnsrs and @psschwei
Fixes #306
I recover the compose module and the work do it on #362, fixing a bug in the loading of the docker-compose files that caused the tests to never finish.
I have also removed the dependency of the docker-compose module, delegating the calls to the client installed in the system.