Add Cockroach DB Container Support#281
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
=======================================
Coverage ? 87.06%
=======================================
Files ? 31
Lines ? 866
Branches ? 61
=======================================
Hits ? 754
Misses ? 79
Partials ? 33 ☔ View full report in Codecov by Sentry. |
|
I'm an engineer from CockroachDB - this looks good to me! |
joelhess
force-pushed
the
Add-cockroachdb
branch
from
dbfb587 to
2cb2e63
Compare
|
Please let me know if there's anything else that I need to do to get this merged. I'm trying to keep it up to date with Master at this point. |
There a few more major-ish changes to prepare for v4.x (e.g. #296). I'd suggest not updating the PR until then (but thank you for putting the work in to keep it up to date). Shall I let you know when |
Yes Please. Thanks for the follow up. |
Add Test Tweak Naming, add to docs Make insecure mode conditional on presence of password Fix Tests Address Linting
joelhess
force-pushed
the
Add-cockroachdb
branch
from
e24db55 to
d092695
Compare
|
@tillahoffmann Is the Main branch ready enough to update this to the new patterns? |
|
Yes, fingers crossed. |
alexanderankin
added
the
community-feat
Adds [Cockroach DB] (https://www.cockroachlabs.com/) module to use with Test containers I had done this previously under #281, but opted to just redo it rather than try to rebase all the things. - [x] Create a new feature directory and populate it with the package structure [described in the documentation](https://testcontainers-python.readthedocs.io/en/latest/#package-structure). Copying one of the existing features is likely the best way to get started. - [x] Implement the new feature (typically in `__init__.py`) and corresponding tests. - [x] Update the feature `README.rst` and add it to the table of contents (`toctree` directive) in the top-level `README.rst`. - [] Add a line `[feature name]` to the list of components in the GitHub Action workflow in `.github/workflows/main.yml` to run tests, build, and publish your package when pushed to the `main` branch. - [x] Rebase your development branch on `main` (or merge `main` into your development branch). - [x] Add Package to pyproject.toml - [ ] Add a line `-e file:[feature name]` to `requirements.in` and open a pull request. Opening a pull request will automatically generate lock files to ensure reproducible builds (see the [pip-tools documentation](https://pip-tools.readthedocs.io/en/latest/) for details). Finally, run `python get_requirements.py --pr=[your PR number]` to fetch the updated requirement files (the build needs to have succeeded). --------- Co-authored-by: joelhess <joelhess@flywheel.io> Co-authored-by: David Ankin <daveankin@gmail.com>
6 participants
You have implemented a new container and would like to contribute it? Great! Here are the necessary steps:
testcontainersdirectory (such astestcontainers/my_fancy_container.py).extras_requiresection ofsetup.py.extra_requireskey torequirements.in.make requirementsfrom the root directory.testsdirectory, e.g.tests/test_my_fancy_container.py.my_fancy_container) to thetest-componentsmatrix in.github/workflows/main.ymlto ensure the tests are run.master(or mergedmasterinto your development branch).