DT-3655 - add external payload count and size to workflow details#3276
DT-3655 - add external payload count and size to workflow details#3276rossedfort merged 9 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| @@ -145,6 +145,10 @@ export const toWorkflowExecution = ( | |||
| const priority = response.workflowExecutionInfo?.priority; | |||
There was a problem hiding this comment.
⚠️ 'response' is possibly 'undefined'.
| historySizeBytes, | ||
| externalPayloadCount, | ||
| externalPayloadSizeBytes, | ||
| searchAttributes, |
There was a problem hiding this comment.
⚠️ Type 'IMemo | undefined' is not assignable to type 'IMemo'.
| externalPayloadCount, | ||
| externalPayloadSizeBytes, | ||
| searchAttributes, | ||
| memo, |
There was a problem hiding this comment.
⚠️ Type 'IWorkflowExecution | null | undefined' is not assignable to type 'IWorkflowExecution | undefined'.
|
|
Screengrabs LGTM! |
|
hey Ross - I had updated the styling in this detail list for the labels to be body medium secondary text to provide some visual distinction between the key and the value. This got the OK from the design team. I'd like to see that updated here. Additionally, all numerical text (so, timestamps, time durations, size values, etc.) should be in our monotype font. Can we update that too? Lastly, can you add in the Docs link next to the SDK label? Idk where my annotation went in figma - i swear i put it in there, but it should go to https://docs.temporal.io/develop/{sdk-type} e.g. https://docs.temporal.io/develop/go/ or https://docs.temporal.io/develop/python/. I had it with the external link icon but I think it should actually be the Thanks! |
…ils header - add class prop to DetailListTextValue and DetailListValue to pass through font-mono - make DetailListLabel text-secondary - add link to SDK developer guides next to SDK logo - replace SDK logos with our own colorblock versions
| text={tooltipText} | ||
| top | ||
| width={tooltipWidth} | ||
| class="min-w-0 font-sans" |
There was a problem hiding this comment.
Is the font-sans a bug fix?
There was a problem hiding this comment.
I added a class prop which gets added to the parent DetailListValue. In some cases we want values to be in monospace font, such as integer values, so I've added font-mono to those instances. This makes it so that the Tooltip doesn't display as monospace font.
Auto-generated version bump from 2.48.2 to 2.48.3 Specific version: 2.48.3 Changes included: - [`59c95f8b`](59c95f8) Add undo/redo support to editable CodeBlock (#3288) - [`89269c62`](89269c6) chore: bump go.temporal.io/api to v1.62.8 and update go.sum (#3298) - [`8e795d8a`](8e795d8) Worker insights (#3087) - [`c58019ae`](c58019a) Use CountSchedules API (#3258) - [`a0d20fcc`](a0d20fc) Add optional initial name to search attribute defintion (#3303) - [`cbaf7549`](cbaf754) DT-3655 - add external payload count and size to workflow details (#3276) - [`0fe2b33c`](0fe2b33) Remove by-type option for activity commands (#3284)
Auto-generated version bump from 2.48.2 to 2.48.3 Specific version: 2.48.3 Changes included: - [`59c95f8b`](59c95f8) Add undo/redo support to editable CodeBlock (#3288) - [`89269c62`](89269c6) chore: bump go.temporal.io/api to v1.62.8 and update go.sum (#3298) - [`8e795d8a`](8e795d8) Worker insights (#3087) - [`c58019ae`](c58019a) Use CountSchedules API (#3258) - [`a0d20fcc`](a0d20fc) Add optional initial name to search attribute defintion (#3303) - [`cbaf7549`](cbaf754) DT-3655 - add external payload count and size to workflow details (#3276) - [`0fe2b33c`](0fe2b33) Remove by-type option for activity commands (#3284) Co-authored-by: laurakwhit <15069288+laurakwhit@users.noreply.github.com>
Description & motivation 💭
Adds external payload count and size to workflow details page header
Screenshots (if applicable) 📸
with external payload(s)
without external payload(s) (unchanged)
Tooltip
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?