Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rossnelson
force-pushed
the
serverless-workers-crud
branch
from
9c01c45 to
751339c
Compare
rossnelson
force-pushed
the
serverless-workers-crud
branch
from
751339c to
44488b5
Compare
rossnelson
force-pushed
the
serverless-workers-crud
branch
from
44488b5 to
d7f777f
Compare
rossnelson
force-pushed
the
serverless-workers-crud
branch
from
69ae808 to
750e13f
Compare
rossnelson
force-pushed
the
serverless-workers-crud
branch
from
740ee5c to
8b91694
Compare
rossnelson
changed the title
andrewzamojc
left a comment
andrewzamojc
left a comment
There was a problem hiding this comment.
I need a little more time with it, but so far so good. 👍
…d Vercel - Add optional cfnTemplate prop to ServerlessWorkerSetupGuide with fallback to default - Thread cfnTemplate through SetupGuideToggle, ServerlessWorkerCreateForm, ServerlessWorkerCreate - Remove Terraform tab from setup guide - Remove Vercel option from compute provider picker
|
Looking and working great! Some UI-specific feedback based on the preview URL. Mostly nits. 🙈 Create Worker Deployment + Create Worker Deployment Version pages[1] Page heading should be a simple [2] [3] We can probably remove the hint on the "Name" field. What do you think? I feel it's self-explanatory. [4] Is Build ID required? I thought this was going to be optional. Let's capitalize the W in Worker. [5] The tooltips are being cutoff. Do we feel both tooltips AND helper texts are necessary? Maybe we should only keep one of them? 
[6] Can rename the confirmation button to simply "Create" instead of Create Worker Deployment. [7] Use [8] Use size [9] For compute provider inputs container, the background should be [10] The vertical steppers should match the style in Audit Log Integration setup. They are also used in Export. We should probably componentize them now that this is the 3rd area to utilize them. [11] Btw love what you did with the AWS Setup Guide on smaller screens. The row for [12] Let's use [13] The links in the setup guide don't have a hover state. Should we simply use our Link component here? Deployments table[1] Let's add [2] I realize this is probably happening because of the deployment name length, but is it possible to align the build status badges across rows so they start at the same position? It would be much easier to scan the list that way. Deployments detail page[1] Use [2] Update gap between View Workflows and Create New Version buttons to [3] Use destructive ghost button for Delete in the row action menu. [4] Love Validate Connection modal. [5] When the version row is expanded, we can add the ability to copy Lambda ARN and IAM Role? |
- Remove tooltips from compute form fields, rely on hint text only - Swap AWS console links in setup guide to Link component - Card padding p-4→p-5, section headings font-semibold→font-medium - Scaling toggle button size sm, remove static name hint text - Add bg-blue-50 to setup guide sidebar card - Delete MenuItem uses destructive prop - Copyable wrapper on lambda/IAM ARN in version compute details - radio-card selected state always border-subtle, slot bg surface-background - timeline-step heading text-base font-medium - Extract handleCreate + rollback helpers in serverless-worker-create - Add error handling for setCurrentDeploymentVersion with full rollback
- Use surface-information (theme-aware indigo tint) instead of bg-blue-50 - Apply surface-information to drawer as well as sidebar card - Remove IAM console link from setup guide - Update setup guide copy to reference CloudFormation template specifically
- Empty state: use workers icon with text-blue-200, flex-wrap buttons - version-row-details: $derived.by with retryCount for $derived suggestion - version-table-row: validateLoading=false in onError callback - deployment.svelte: reset deleteError before retry - deployments.ts: narrow isVersionSummaryNew to include non-null deploymentVersion - version-table-row: remove ! non-null assertions (now covered by type guard) - scaling toggle: add chevron-up/down trailingIcon in both create forms - create-version-form: add try/catch in onUpdate
All three forms (create deployment, create version, edit version) shared identical compute field markup. Extracted into ComputeFields with $bindable props. Also removes leftover Tooltip/Icon wrappers from edit-version-form that were inconsistent with the other forms.
- Extract DeleteConfirmModal with shared state, template, and logic; DeleteDeploymentModal and DeleteVersionModal become thin wrappers - Show Create Worker Deployment button on instances tab (mirrors deployments tab)
laurakwhit
left a comment
laurakwhit
left a comment
There was a problem hiding this comment.
One small comment below, but otherwise 🚀
| }); | ||
| </script> | ||
|
|
||
| <Modal |
There was a problem hiding this comment.
Seems like src/lib/components/deployments/delete-confirm-modal.svelte in addition to src/lib/components/deployments/delete-deployment-modal.svelte is redundant.
With this comment I was thinking a more reusable component (e.g. src/lib/components/delete-confirmation-modal.svelte) that we could use here, but in other places as well (similar to _delete-modal.svelte in Cloud).
4 participants
Summary
Implements full CRUD UI for serverless worker deployments under `/workers/deployments/`:
serverless-ui-walkthrough.mov
Also see worker code at: https://github.com/rossnelson/temporal-serverless-worker/blob/main/SETUP.md
Deployments
Versions
Compute Provider
Infrastructure
Test plan