Skip to content

Make npm start script POSIX compliant#192

Merged
stevekinney merged 1 commit intomainfrom
fix-startup-sript-in-dash
Jan 4, 2022
Merged

Make npm start script POSIX compliant#192
stevekinney merged 1 commit intomainfrom
fix-startup-sript-in-dash

Conversation

@feedmeapples
Copy link
Copy Markdown
Contributor

@feedmeapples feedmeapples commented Jan 3, 2022

What was changed

source wouldn't work with some shells such as ubuntu dash (and wsl ubuntu)

from what i've read . seems more universal and POSIX compliant https://ss64.com/bash/source.html

Why?

Fixes npm start in wsl & ubuntu

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@stevekinney stevekinney merged commit 7eb1a49 into main Jan 4, 2022
@stevekinney stevekinney deleted the fix-startup-sript-in-dash branch January 4, 2022 00:28
rossnelson added a commit that referenced this pull request Apr 3, 2026
- lodash: ^4.17.21 -> ^4.18.1 (CVE-2026-4800, CVE-2026-2950, CVE-2025-13465)
- svelte: 5.53.3 -> 5.55.1 (CVE-2026-27902, CVE-2026-27901)
- @sveltejs/kit: 2.53.0 -> 2.55.0 (DoS via form deserialization)
- storybook: ^8.6.11 -> ^8.6.18 (CVE-2026-27148)
- tar-fs: >=2.1.2 -> ^3.1.2 (CVE-2025-59343)

Resolves Dependabot alerts #233, #232, #159, #204, #203, #194, #193, #207, #192, #127.
rossnelson added a commit that referenced this pull request Apr 8, 2026
#3269)

- lodash: ^4.17.21 -> ^4.18.1 (CVE-2026-4800, CVE-2026-2950, CVE-2025-13465)
- svelte: 5.53.3 -> 5.55.1 (CVE-2026-27902, CVE-2026-27901)
- @sveltejs/kit: 2.53.0 -> 2.55.0 (DoS via form deserialization)
- storybook: ^8.6.11 -> ^8.6.18 (CVE-2026-27148)
- tar-fs: >=2.1.2 -> ^3.1.2 (CVE-2025-59343)

Resolves Dependabot alerts #233, #232, #159, #204, #203, #194, #193, #207, #192, #127.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants