Skip to content

Show authenticated user's avatar#191

Merged
stevekinney merged 3 commits intomainfrom
user-icon
Jan 4, 2022
Merged

Show authenticated user's avatar#191
stevekinney merged 3 commits intomainfrom
user-icon

Conversation

@feedmeapples
Copy link
Copy Markdown
Contributor

@feedmeapples feedmeapples commented Jan 3, 2022

What was changed

  • fixes log in button to force hitting ui-server's auth URL
  • shows authenticated user's avatar
    image

Why?

let's user know when auth succeeds

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

Comment thread src/lib/stores/user.ts Outdated

export const user = writable<User>(null);

const loadUser = async (): Promise<void> => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be better off just as a single API call here? https://github.com/temporalio/ui/blob/main/src/routes/__layout.svelte#L11-L21

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@stevekinney stevekinney merged commit eb430db into main Jan 4, 2022
@stevekinney stevekinney deleted the user-icon branch January 4, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants