Remove side navigation; break out DataConvertorStatus#163
Merged
stevekinney merged 1 commit intomainfrom Dec 9, 2021
Merged
Conversation
GiantRobots
reviewed
Dec 9, 2021
| <Icon src={StatusOnline} class="mx-auto text-green-500 w-8 h-8" /> | ||
| </Tooltip> | ||
| {/if} | ||
| {/if} |
Collaborator
There was a problem hiding this comment.
Much better to have this as a component.
GiantRobots
approved these changes
Dec 9, 2021
| </WorkflowsSummaryTable> | ||
| {:else} | ||
| <WorkflowsEmptyState /> | ||
| {/if} |
Collaborator
There was a problem hiding this comment.
Looks like we're missing an error state here? Or are we expecting code further up to error on it?
Contributor
Author
There was a problem hiding this comment.
@josephriosIO is currently refactoring this in #159.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the side navigation, removes the sticky header, breaks out the Data Converter status into its own component.