Adds basedpyright support to poe lint
#1240
Merged
+544
−770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tconley1428
changed the title
poe formatpoe lint
VegetarianOrc
approved these changes
Dec 18, 2025
Contributor
VegetarianOrc
left a comment
VegetarianOrc
left a comment
There was a problem hiding this comment.
LGTM pending the last few fixes. TY for tanking this giant project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added running
basedpyrightto lint checks and fixed errors/warnings.Why?
Many users use
basedpyrightor IDEs which do.Checklist
Closes [Feature Request] Add BasedPyright as a required typecheck #1232
How was this tested: