tls.createSecurePair is being runtime-deprecated

[ChALkeR]

Ref: nodejs/node#11349

Used in:

tedious-1.14.0.tgz/lib/message-io.js:117:      this.securePair = tls.createSecurePair(credentials);

See also #135.
See e.g. sidorares/node-mysql2#367 for a feature detection example.

[tvrprasad]

@ChALkeR Thanks for the pointer. This will be helpful when we get to this. Feel free to send a PR if you feel inspired :-)

[arthurschreiber]

@tvrprasad: @ChALkeR is part of the Node.js team and this post is mostly intended as a heads-up for us to know that this feature is deprecated. I don't think he actually uses tedious. 😄

@ChALkeR: I've known about this deprecation for a while, but the documentation around this deprecation is really sparse. The examples I've seen so far (like the PR for node-mysql) focus on "simple" TLS upgrades, where the connection is just switched from non-TLS to TLS.

In TDS, the TLS upgrade is a lot more involved, all the handshaking packets need to be wrapped into TDS messages, and then once the connection is established, all further TLS packets don't need to be wrapped anymore. Implementing this via tls.createSecurePair was pretty straightforward, but the last time I tried this via TLSSocket, I could not get it to work. 😞

I'll try again when I get to it, but i don't think much has changed.

Another issue I ran into is that wrapping a socket from the readable-stream package into a TLSSocket would cause a segfault (!) of the Node.js process. Unfortunately, I don't have reproduction steps handy right now. 😞

[tvrprasad]

@arthurschreiber Thanks for the info :-)

but the last time I tried this via TLSSocket, I could not get it to work.

If this work is on github, please send me a pointer. I'm curious to check it out.

[ariskemper]

@tvrprasad @arthurschreiber Here is information on how to replace tls.createSecurePair https://nodejs.org/dist/latest-v6.x/docs/api/tls.html#tls_class_securepair

[olange]

Encoutered the same issue on Node v8.0.1. My app reports following error, after trying to establish an encrypted connexion:

(node:6344) [DEP0064] DeprecationWarning: tls.createSecurePair() is deprecated. Please use tls.Socket instead.

I am using patriksimek/node-mssql and the tedious driver (the default driver of node-mssql) to access our Microsoft SQL Server database.

[deluxor]

Same issue as @olange using node-mssql with tedious driver.

Listening on port 4000
(node:4402) [DEP0064] DeprecationWarning: tls.createSecurePair() is deprecated. Please use tls.Socket instead.

Please don't take me wrong and I really appreciate your efforts keeping this module up but Is there any prediction when it will be fixed?

[CunhaGus]

Using the package 'mssql' and using options:
{
encrypt: true
}

(node:13508) [DEP0064] DeprecationWarning: tls.createSecurePair() is deprecated. Please use tls.Socket instead.

[akanieski]

When Node team deprecates something like this whats the timeframe for removal in Node? Just curious.

[bminer]

Probably will be removed in Node 9 or 10. The feature has been doc-deprecated for at least 4 years. :-/ This is one of the only popular NPM packages still using it.

[iamvijaydev]

Does anyone from collaborators have any timeline on when the change will be released?

[Iiridayn]

Getting this today since I just updated our systems to node 8.9.0 lts. I've got two heavy projects right now, but if they both ease up, I'll see if I can spare some time to fixing this.

[Suraiya-Hameed]

@Iiridayn That would be awesome!
I did have a look at it, but couldn't figure out how to get the handshake packet from TLSSocket, stuck at same point as #515 (comment) 😕
Would love to hear if you have ideas on that.