Skip to content

Fixed shutdowns. #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s3rius merged 1 commit into from
Mar 15, 2025
Merged

Fixed shutdowns. #425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions taskiq/cli/worker/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ async def shutdown_broker(broker: AsyncBroker, timeout: float) -> None:
try:
ret_val = await asyncio.wait_for(broker.shutdown(), timeout) # type: ignore
if ret_val is not None:
logger.info("Broker returned value on shutdown: '%s'", str(ret_val))
logger.info("Broker has returned value on shutdown: '%s'", str(ret_val))
except asyncio.TimeoutError:
logger.warning("Cannot shutdown broker gracefully. Timed out.")
logger.warning("Broker.shutdown cannot be completed in %s seconds.", timeout)
except Exception as exc:
logger.warning(
"Exception found while terminating: %s",
"Exception found while shutting down broker: %s",
exc,
exc_info=True,
)
Expand Down Expand Up @@ -151,8 +151,7 @@ def interrupt_handler(signum: int, _frame: Any) -> None:
**receiver_kwargs, # type: ignore
)
loop.run_until_complete(receiver.listen(shutdown_event))
except KeyboardInterrupt:
logger.warning("Worker process interrupted.")
finally:
loop.run_until_complete(shutdown_broker(broker, args.shutdown_timeout))


Expand Down