-
Notifications
You must be signed in to change notification settings - Fork 38
Propagate variants attributes to method definitions. #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you add a test for this feature? I'm not sure what are these imeta parameters at all and how we can apply meta parameters to "methods" which aren't actually the methods. |
|
In fact, the attributes specified to the variants of the error were propagated to the enum definition but not to the various matches in the methods definitions. |
|
Can this be merged yet, @tailhook? |
|
Well, sorry for being silent for so much time here. The problem that might be with this PR, is that While it makes sense propagate conditional compilation attributes (i.e. |
|
|
Ah, right. I've misread it at a glance.
It's there in this pull request: Because conditional compilation requires it: So I guess this will break docstrings on variants (yet to check) |
|
From what I observe it works fine. Thanks, for contributing! Sorry for sooooo long delay. |
|
^^ |
No description provided.