Support favorites retrieval and modification#591
Closed
jorwoods wants to merge 22 commits intotableau:developmentfrom
Closed
Support favorites retrieval and modification#591jorwoods wants to merge 22 commits intotableau:developmentfrom
jorwoods wants to merge 22 commits intotableau:developmentfrom
Conversation
t8y8
reviewed
May 12, 2020
Contributor
Author
|
Added testing, and made the favorites load in as a dictionary attached to the user item. |
The favorites item is now a dictionary. The user_item has been altered to reflect this.
jorwoods
force-pushed
the
jorwoods/user_favorites
branch
from
e364a9c to
40cd444
Compare
jorwoods
force-pushed
the
jorwoods/user_favorites
branch
from
581088b to
29768db
Compare
jorwoods
force-pushed
the
jorwoods/user_favorites
branch
from
2008932 to
301c257
Compare
Contributor
Author
|
Rebased on current development branch Fixed code style issues @t8y8 does this look ready to merge? |
Contributor
Author
|
@t8y8 Anything else need to change? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #39
This may not be the intended implementation, or be how it was intended to be solved. I took a pass at it to give myself a route to modify favorites for my users. After I wrote this, I noticed stubs for it in the users endpoint, but wasn't sure if that was still the plan as favorites has a separate base url. I haven't written extensive tests for this yet.
Also wasn't sure if "Favorites" technically should have their own model, or just an endpoint. Sort of ambiguous as a favorites object would just be a wrapper around a workbook/view/project/datasource.