feat: add claimable_on_close_sats to ChannelDetails
#33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add claimable_on_close_sats field to ChannelDetails struct, computed from the channel monitor's ClaimableOnChannelClose balance. This replaces the workaround of approximating claimable amount using outbound_capacity + reserve. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
ben-kaufman
approved these changes
Jan 16, 2026
- Move imports to top of file (LdkBalance, HashMap, ChannelId) - Replace unwrap() with if let Some() for safer access - Change "force-closed" to "closed" in doc comment - Simplify from_ldk_with_balance to avoid code duplication - Add import rule to AGENTS.md Co-Authored-By: Claude Opus 4.5 <[email protected]>
coreyphillips
approved these changes
Jan 17, 2026
ovitrif
changed the title
claimable_on_close_sats to ChannelDetails
Author
|
Keeping this PR open until I integrate in bitkit-android to confirm its useful and doesn't need any further changes (just hygiene protocol, I know by the logic it should work). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
claimable_on_close_satsfield toChannelDetailsstructClaimableOnChannelClosebalanceNoneif no monitor exists yet (pre-funding)outbound_capacity + counterparty_reserveChanges
src/types.rs: Added field andfrom_ldk_with_balance()conversion methodsrc/lib.rs: Updatedlist_channels()to compute balances from monitorsbindings/ldk_node.udl: Added field to bindingsv0.7.0-rc.7Test plan
cargo build- Compiles successfullycargo clippy- No warnings related to changesxcframeworkchecksum matchesPackage.swiftclaimable_on_close_satsmatcheslist_balances()ClaimableOnChannelClose.amount_satoshisUsage
bitkit-android can replace:
With:
Release